Further improvements for db pooling #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
|
A question @danceb : feel free to comment or not ... how you wish... You write:
If using pooling were an improvement for everyone, then why wouldn't we want to have it as a default? Or asked in another way:
|
|
In my opinion pooling would be an improvement for everyone, otherwise I would not recommended this as PR ;-) Otherwise setting the optimal values of the parameters for So I wouldn't go with it, to set the default values initially for anybody. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two adjustments.
create_engine().ENV.Feel free to release a new package version of qwc-services core or just rebuild 1.4.5 (?)